Skip to content

Use SimpleHandler on AttrRW only#186

Merged
GDYendell merged 6 commits intomainfrom
126_simple_handler
Aug 13, 2025
Merged

Use SimpleHandler on AttrRW only#186
GDYendell merged 6 commits intomainfrom
126_simple_handler

Conversation

@shihab-dls
Copy link
Contributor

fixes #126

This removes use of SimpleHandler from AttrW and defaults it in AttrRW. Testing AttrW with this handler has been removed, and testing with AttrRW amended to check we can read the value we set.

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.20%. Comparing base (ee8a5e2) to head (d9b10b1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   92.20%   92.20%   -0.01%     
==========================================
  Files          40       40              
  Lines        2015     2013       -2     
==========================================
- Hits         1858     1856       -2     
  Misses        157      157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shihab-dls shihab-dls requested a review from GDYendell August 11, 2025 14:58
Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment

@shihab-dls shihab-dls requested a review from GDYendell August 13, 2025 14:35
@GDYendell GDYendell merged commit f30128b into main Aug 13, 2025
18 checks passed
@GDYendell GDYendell deleted the 126_simple_handler branch August 13, 2025 15:06
gilesknap pushed a commit that referenced this pull request Aug 18, 2025
gilesknap added a commit that referenced this pull request Aug 18, 2025
first pass at helm chart for fastcs instances

fix service name

better port exposure for service.yaml

add helm chart publishing

remove service account creation from helm

switch to using Charts folder with subfolders for charts

add schema for fastcs-instance chart values.yaml

publish chart values schemas

publish chart values schemas

add schema generation to pre-commit

fixing the fastcs-instance chart schema

Add setuptools to dev requirements for aioca

Remove bodge from CI

Update DataType.validate to attempt cast (#182)

Do not propagate DRVL and DRVH to in type records in CA transport (#185)

Use SimpleHandler on AttrRW only (#186)

Add API to update attributes once when Backend.serve() called (#188)

Add ONCE constant to update attribute only when serve called

add debug features to helm chart

repair incorrect helm chart

debug now working

fix non-debug mode

fix incorrect terminationGracePeriodSeconds

add debug entrypoint

move initCommand into values

rename charts to remove "instance"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only use SimpleHandler for AttrRW

2 participants